]> git.karo-electronics.de Git - linux-beck.git/commit
fs: fix iversion handling
authorChristoph Hellwig <hch@infradead.org>
Tue, 19 Nov 2013 15:17:07 +0000 (07:17 -0800)
committerBen Myers <bpm@sgi.com>
Thu, 5 Dec 2013 22:36:21 +0000 (16:36 -0600)
commitdff6efc326a4d5f305797d4a6bba14f374fdd633
treec0370871b238354313a3809b8911d7f633ed0c3a
parentb7d961b35b3ab69609aeea93f870269cb6e7ba4d
fs: fix iversion handling

Currently notify_change directly updates i_version for size updates,
which not only is counter to how all other fields are updated through
struct iattr, but also breaks XFS, which need inode updates to happen
under its own lock, and synchronized to the structure that gets written
to the log.

Remove the update in the common code, and it to btrfs and ext4,
XFS already does a proper updaste internally and currently gets a
double update with the existing code.

IMHO this is 3.13 and -stable material and should go in through the XFS
tree.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/attr.c
fs/btrfs/inode.c
fs/ext4/inode.c