]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: et131x: zero allocation of fbr to prevent random address access
authorMark Einon <mark.einon@gmail.com>
Tue, 23 Sep 2014 19:41:11 +0000 (20:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Sep 2014 06:38:15 +0000 (23:38 -0700)
commite112eb598db4fb7b99086c33765cf262dcfda0d2
tree7bd05407363423ac589e464961befa99a1dde9c6
parentbfe945c8e1260e405a7a257719c9e2cf77cafa4e
staging: et131x: zero allocation of fbr to prevent random address access

If et131x_rx_dma_memory_alloc() allocates rx_ring->fbr[0] but fails to
allocate rx_ring->fbr[1], this leaves fbr[0]->ring_virtaddr with the
possibility of being accessed in et131x_rx_dma_memory_free() as it
contains a random value, potentially causing an oops.

Fix this by zeroing the fbr memory on allocation. Subsequent frees of
this fbr memory explicitly zeros the ring_virtaddr value.

Reported-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/et131x.c