]> git.karo-electronics.de Git - karo-tx-linux.git/commit
spidev: fix hang when transfer_one_message fails
authorDaniel Santos <daniel.santos@pobox.com>
Sun, 5 Jan 2014 23:39:26 +0000 (17:39 -0600)
committerMark Brown <broonie@linaro.org>
Mon, 6 Jan 2014 12:54:39 +0000 (12:54 +0000)
commite120cc0dcf2880a4c5c0a6cb27b655600a1cfa1d
tree1060278b6895c6ff42c5962f3f5cd5a5ac006529
parent6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae
spidev: fix hang when transfer_one_message fails

This corrects a problem in spi_pump_messages() that leads to an spi
message hanging forever when a call to transfer_one_message() fails.
This failure occurs in my MCP2210 driver when the cs_change bit is set
on the last transfer in a message, an operation which the hardware does
not support.

Rationale
Since the transfer_one_message() returns an int, we must presume that it
may fail.  If transfer_one_message() should never fail, it should return
void.  Thus, calls to transfer_one_message() should properly manage a
failure.

Fixes: ffbbdd21329f3 (spi: create a message queueing infrastructure)
Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org
drivers/spi/spi.c