]> git.karo-electronics.de Git - linux-beck.git/commit
fs: configfs: don't return anything from drop_link
authorAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Mon, 28 Nov 2016 12:22:42 +0000 (13:22 +0100)
committerChristoph Hellwig <hch@lst.de>
Thu, 1 Dec 2016 09:50:49 +0000 (10:50 +0100)
commite16769d4bca67218531505ad1a8365d227fedcf9
treea60ede285d2cb1c296139c7bd1b95309e29a256b
parente5517c2a5a49ed5e99047008629f1cd60246ea0e
fs: configfs: don't return anything from drop_link

Documentation/filesystems/configfs/configfs.txt says:

"When unlink(2) is called on the symbolic link, the source item is
notified via the ->drop_link() method.  Like the ->drop_item() method,
this is a void function and cannot return failure."

The ->drop_item() is indeed a void function, the ->drop_link() is
actually not. This, together with the fact that the value of ->drop_link()
is silently ignored suggests, that it is the ->drop_link() return
type that should be corrected and changed to void.

This patch changes drop_link() signature and all its users.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
[hch: reverted reformatting of some code]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Documentation/filesystems/configfs/configfs.txt
drivers/nvme/target/configfs.c
drivers/target/target_core_fabric_configfs.c
drivers/usb/gadget/configfs.c
drivers/usb/gadget/function/uvc_configfs.c
include/linux/configfs.h