]> git.karo-electronics.de Git - linux-beck.git/commit
dcache: Don't set DISCONNECTED on "pseudo filesystem" dentries
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 29 Jun 2012 20:20:47 +0000 (16:20 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 9 Nov 2013 05:16:33 +0000 (00:16 -0500)
commite1a24bb0aa6abaa86b5a95638722ea2036dbaadd
tree04c1731bae6e7812ed30cb2097c391ae469d3ef7
parent7632e465feb182cadc3c9aa1282a057201818a8c
dcache: Don't set DISCONNECTED on "pseudo filesystem" dentries

I can't for the life of me see any reason why anyone should care whether
a dentry that is never hooked into the dentry cache would need
DCACHE_DISCONNECTED set.

This originates from 4b936885ab04dc6e0bb0ef35e0e23c1a7364d9e5 "fs:
improve scalability of pseudo filesystems", which probably just made the
false assumption the DCACHE_DISCONNECTED was meant to be set on anything
not connected to a parent somehow.

So this is just confusing.  Ideally the only uses of DCACHE_DISCONNECTED
would be in the filehandle-lookup code, which needs it to ensure
dentries are connected into the dentry tree before use.

I left d_alloc_pseudo there even though it's now equivalent to
__d_alloc(), just on the theory the name is better documentation of its
intended use outside dcache.c.

Cc: Nick Piggin <npiggin@kernel.dk>
Acked-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c