]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dm ioctl: do not leak argv if target message only contains whitespace
authorJesper Juhl <jj@chaosbits.net>
Wed, 7 Mar 2012 19:09:34 +0000 (19:09 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Mar 2012 19:31:41 +0000 (12:31 -0700)
commite2ece17aceb773d9be4f0eb75f7f7360bcf06259
tree81b99c5f61e141cd96b537f6cf8e1cd02d0ab913
parenta5a2f494f9eff644c5369807a472cc6d9722baed
dm ioctl: do not leak argv if target message only contains whitespace

commit 902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c upstream.

If 'argc' is zero we jump to the 'out:' label, but this leaks the
(unused) memory that 'dm_split_args()' allocated for 'argv' if the
string being split consisted entirely of whitespace.  Jump to the
'out_argv:' label instead to free up that memory.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-ioctl.c