]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] hdpvr: fix iteration over uninitialized lists in hdpvr_probe()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Wed, 3 Jul 2013 19:17:34 +0000 (16:17 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 26 Jul 2013 13:32:48 +0000 (10:32 -0300)
commite2f11c58ae49d57b0e634685dd944c1771ba38c0
tree7041da855d99ee57e181c72f26441d45a939c5b7
parent4f24abb51ffe24d1a1442fdd3648a2e521487c1b
[media] hdpvr: fix iteration over uninitialized lists in hdpvr_probe()

free_buff_list and rec_buff_list are initialized in the middle of hdpvr_probe(),
but if something bad happens before that, error handling code calls hdpvr_delete(),
which contains iteration over the lists (via hdpvr_free_buffers()).
The patch moves the lists initialization to the beginning and by the way fixes
goto label in error handling of registering videodev.
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/hdpvr/hdpvr-core.c