]> git.karo-electronics.de Git - linux-beck.git/commit
fsnotify: Remove fsnotify_duplicate_mark()
authorJan Kara <jack@suse.cz>
Thu, 22 Dec 2016 09:15:20 +0000 (10:15 +0100)
committerPaul Moore <paul@paul-moore.com>
Fri, 23 Dec 2016 21:40:32 +0000 (16:40 -0500)
commite3ba730702af370563f66cb610b71aa0ca67955e
tree6a7dd8a17c9fde8851366f785faa4d9ce6462fe2
parent533c7b69c764ad5febb3e716899f43a75564fcab
fsnotify: Remove fsnotify_duplicate_mark()

There are only two calls sites of fsnotify_duplicate_mark(). Those are
in kernel/audit_tree.c and both are bogus. Vfsmount pointer is unused
for audit tree, inode pointer and group gets set in
fsnotify_add_mark_locked() later anyway, mask and free_mark are already
set in alloc_chunk(). In fact, calling fsnotify_duplicate_mark() is
actively harmful because following fsnotify_add_mark_locked() will leak
group reference by overwriting the group pointer. So just remove the two
calls to fsnotify_duplicate_mark() and the function.

Signed-off-by: Jan Kara <jack@suse.cz>
[PM: line wrapping to fit in 80 chars]
Signed-off-by: Paul Moore <paul@paul-moore.com>
fs/notify/mark.c
include/linux/fsnotify_backend.h
kernel/audit_tree.c