]> git.karo-electronics.de Git - mv-sheeva.git/commit
Input: xpad - ensure xpad->bulk_out is initialized before submitting urb
authorAxel Lin <axel.lin@gmail.com>
Thu, 18 Nov 2010 07:59:34 +0000 (23:59 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 18 Nov 2010 08:16:44 +0000 (00:16 -0800)
commite3f0f0a6c11b049f1be603dcfec82d2a8643f5fd
treef77ff559fb6c1af542217627678af719fdc32dce
parent20a4c261ad9cec39942257b1f91765a4b238db05
Input: xpad - ensure xpad->bulk_out is initialized before submitting urb

As pointed out by Oliver Neukum:
xpad->irq_in is currently submitted before xpad->bulk_out is allocated.
That however is a race, because the callback for irq_in can call
xpad360w_process_packet(), which will in turn submit the bulk URB.

This patch moves initialization for xpad->bulk_out earlier, so we can
ensure xpad->bulk_out is initialized before submitting urb.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/joystick/xpad.c