]> git.karo-electronics.de Git - linux-beck.git/commit
mac80211: Fix FILS AEAD protection in Association Request frame
authorJouni Malinen <jouni@qca.qualcomm.com>
Sat, 4 Feb 2017 11:59:22 +0000 (13:59 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 6 Feb 2017 06:42:39 +0000 (07:42 +0100)
commite479ab651f071dbd1518ce8fb121c7f42f2bb97d
treedae5b419dbf942e66495e705b3f0ffb691abd0a2
parent7892032cfe67f4bde6fc2ee967e45a8fbaf33756
mac80211: Fix FILS AEAD protection in Association Request frame

Incorrect num_elem parameter value (1 vs. 5) was used in the
aes_siv_encrypt() call. This resulted in only the first one of the five
AAD vectors to SIV getting included in calculation. This does not
protect all the contents correctly and would not interoperate with a
standard compliant implementation.

Fix this by using the correct number. A matching fix is needed in the AP
side (hostapd) to get FILS authentication working properly.

Fixes: 39404feee691 ("mac80211: FILS AEAD protection for station mode association frames")
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/fils_aead.c