]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ocfs2: double evaluation concerns in mlog_errno()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Apr 2015 23:43:56 +0000 (09:43 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 7 Apr 2015 23:43:56 +0000 (09:43 +1000)
commite49af8449f7202eef1b9b889b2f98ab067729784
tree73b3cb9b8d7882c11ca9dc959bd3f96a6aed0bab
parent1d13563ba3d93675e1e2b58c26c6dd4f27a18ad2
ocfs2: double evaluation concerns in mlog_errno()

It won't happen in real life, but for consistency etc then we should
only evaluate the "st" parameter once.

Also, since not all callers use the new return, it causes at static
checker warning:
fs/ocfs2/export.c:138 ocfs2_get_dentry() warn: unchecked 'PTR_ERR'

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: alex chen <alex.chen@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/cluster/masklog.h