]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hwmon: (via-cputemp) Use get_online_cpus to avoid races involving CPU hotplug
authorSilas Boyd-Wickizer <sbw@mit.edu>
Wed, 8 Aug 2012 22:42:14 +0000 (08:42 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 8 Aug 2012 22:42:14 +0000 (08:42 +1000)
commite546a9c47f73052388f8689d1b9cdc0db588f3db
tree5a404853a7cf59da5a91e0e5fdc242b1f7b4ea89
parente7882d6c40874a5b5033ca85f7508a602a60b662
hwmon: (via-cputemp) Use get_online_cpus to avoid races involving CPU hotplug

via_cputemp_init loops with for_each_online_cpu, adding
platform_devices, then calls register_hotcpu_notifier.  If a CPU is
offlined between the loop and register_hotcpu_notifier, then later
onlined, via_cputemp_device_add will attempt to add platform devices
with the same ID.  A similar race occurs during via_cputemp_exit,
after the module calls unregister_hotcpu_notifier, a CPU might offline
and a device will exist for a CPU that is offline.

This fix surrounds for_each_online_cpu and register_hotcpu_notifier
with get_online_cpus+put_online_cpus; and surrounds
unregister_hotcpu_notifier and device unregistering with
get_online_cpus+put_online_cpus.

Build tested.

Signed-off-by: Silas Boyd-Wickizer <sbw@mit.edu>
Acked-by: Harald Welte <laforge@gnumonks.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/via-cputemp.c