]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ide-tape: remove back-to-back REQUEST_SENSE detection
authorTejun Heo <tj@kernel.org>
Sat, 18 Apr 2009 22:00:41 +0000 (07:00 +0900)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 15 Jun 2009 16:40:16 +0000 (09:40 -0700)
commite5a2c03e61c8bc05e573b05e424dc545894f18ff
treeae785ebf09b4342d3357dec852e012523a64a9d4
parent1e4f26e2ab78b52720c3ef2b3c5fb015b11c4867
ide-tape: remove back-to-back REQUEST_SENSE detection

commit 36999a5af1b6c5379e59f0ddf434db08d03c19e4 upstream.

Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when
checking for back-to-back request sense issues but drive->pc can be
NULL and even when it's not NULL, it's not safe to dereference it once
the previous command is complete because pc could have been freed or
was on stack.  Kill back-to-back REQUEST_SENSE detection.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ide/ide-tape.c