]> git.karo-electronics.de Git - linux-beck.git/commit
MIPS: Remove incorrect NULL check in local_flush_tlb_page()
authorEmil Goode <emilgoode@gmail.com>
Sat, 5 Jul 2014 23:23:58 +0000 (01:23 +0200)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 30 Jul 2014 18:59:43 +0000 (20:59 +0200)
commite5cd534a3125af4aaa2feb7de9f7700d0a8e91d1
tree7485269311bbc78ed6af2ed2fc8a8ac41fed54fc
parent0fc0708a8a2e6ff5e9ab633185903831fe478994
MIPS: Remove incorrect NULL check in local_flush_tlb_page()

We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent was to make sure vma is
not NULL but this is not necessary since the bug pre-dates GIT history
and seem to never have caused a problem. The tlb-4k and tlb-8k versions
of local_flush_tlb_page() don't bother checking if vma is NULL, also
vma is dereferenced before being passed to local_flush_tlb_page(),
thus it is safe to remove this NULL check.

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Reviewed-by: Jonas Gorski <jogo@openwrt.org>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/7264/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/mm/tlb-r3k.c