]> git.karo-electronics.de Git - linux-beck.git/commit
xfs: remove pointless pointer increment in xfs_dir2_block_compact()
authorEric Sandeen <sandeen@redhat.com>
Mon, 14 Apr 2014 09:06:46 +0000 (19:06 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 14 Apr 2014 09:06:46 +0000 (19:06 +1000)
commite5e98bc64df122c3c0fb562c53dac5c5dfc64975
treec9b2bc7b5314dc1460167e8c796d00fd41c1a34d
parentbbe4c668694cb22a6016d3845c9b362c44e8341f
xfs: remove pointless pointer increment in xfs_dir2_block_compact()

xfs_dir2_block_compact() is passed a pointer to *blp, and
advances it locally - but nobody uses the pointer (locally)
after that.

This behavior came about as part of prior refactoring,

20f7e9f xfs: factor dir2 block read operations

and looking at the code as it was before, it seems quite clear
that this change introduced a bug; the pre-refactoring code
expects blp to be modified after compaction.
And indeed it did; see this commit which fixed it:

37f1356 xfs: recalculate leaf entry pointer after compacting a dir2 block

So the bug was introduced & resolved in the 3.8 cycle.

Whoops.  Well, it's fixed now, and mystery solved; just remove
the now-pointless local increment of the blp pointer.

(I guess we should have run clang earlier!)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_dir2_block.c