]> git.karo-electronics.de Git - linux-beck.git/commit
net/mlx4_en: Call register_netdevice in the proper location
authorIdo Shamay <idos@mellanox.com>
Tue, 24 Mar 2015 13:18:38 +0000 (15:18 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2015 19:22:52 +0000 (15:22 -0400)
commite5eda89d97ec256ba14e7e861387cc0468259c18
treeb63815df3edb36b386c1a013821093a4a7c25dfc
parente43e50524e6b00522cc7a1deee3eebd7046cde6f
net/mlx4_en: Call register_netdevice in the proper location

Netdevice registration should be performed a the end of the driver
initialization flow. If we don't do that, after calling register_netdevice,
device callbacks may be issued by higher layers of the stack before
final configuration of the device is done.

For example (VXLAN configuration race), mlx4_SET_PORT_VXLAN was issued
after the register_netdev command. System network scripts may configure
the interface (UP) right after the registration, which also attach
unicast VXLAN steering rule, before mlx4_SET_PORT_VXLAN was called,
causing the firmware to fail the rule attachment.

Fixes: 837052d0ccc5 ("net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling")
Signed-off-by: Ido Shamay <idos@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_netdev.c