]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[TCP]: Fix minisock tcp_create_openreq_child() typo.
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 8 Mar 2007 07:43:47 +0000 (08:43 +0100)
committerAdrian Bunk <bunk@stusta.de>
Thu, 8 Mar 2007 07:43:47 +0000 (08:43 +0100)
commite62a305abfd6ec65c6d5aab05ed94109408f4c5c
treedfaa84403ad11faedfe533d991f7030bc2c2bb58
parent8cf5c27708b395705f9878e3b444dd9378e14f60
[TCP]: Fix minisock tcp_create_openreq_child() typo.

On 2/28/07, KOVACS Krisztian <hidden@balabit.hu> wrote:
>
>   Hi,
>
>   While reading TCP minisock code I've found this suspiciously looking
> code fragment:
>
> - 8< -
> struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb)
> {
>         struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC);
>
>         if (newsk != NULL) {
>                 const struct inet_request_sock *ireq = inet_rsk(req);
>                 struct tcp_request_sock *treq = tcp_rsk(req);
>                 struct inet_connection_sock *newicsk = inet_csk(sk);
>                 struct tcp_sock *newtp;
> - 8< -
>
>   The above code initializes newicsk to inet_csk(sk), isn't that supposed
> to be inet_csk(newsk)?  As far as I can tell this might leave
> icsk_ack.last_seg_size zero even if we do have received data.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
net/ipv4/tcp_minisocks.c