]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cifs: fix the format specifiers in sid_to_str
authorJeff Layton <jlayton@redhat.com>
Mon, 5 Nov 2012 11:47:02 +0000 (06:47 -0500)
committerJeff Layton <jlayton@redhat.com>
Mon, 5 Nov 2012 11:47:02 +0000 (06:47 -0500)
commite6b7f58ed499caf4eeccae1fc133ec06315c7e75
treea9b25d3b20b23410cb3458d888c650d71db045c9
parentdeaa8d632796e01558bc2095c8328b86b9a659ef
cifs: fix the format specifiers in sid_to_str

The format specifiers are for signed values, but these are unsigned.
Given that '-' is a delimiter between fields, I don't think you'd get
what you'd expect if you got a value here that would overflow the sign
bit.

The version and authority fields are 8 bit values so use a "hh" length
modifier there. The subauths are 32 bit values, so there's no need to
use a "l" length modifier there.

Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
fs/cifs/cifsacl.c