]> git.karo-electronics.de Git - karo-tx-linux.git/commit
PCI: hv: Delete the device earlier from hbus->children for hot-remove
authorDexuan Cui <decui@microsoft.com>
Thu, 10 Nov 2016 07:19:52 +0000 (07:19 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 16 Nov 2016 22:46:44 +0000 (16:46 -0600)
commite74d2ebdda33b3bdd1826b5b92e9aa45bdf92bb3
tree77333536f5741d3117d404b403f3123d098d6b11
parent17978524a636d007e6b929304ae3eb5ea0371019
PCI: hv: Delete the device earlier from hbus->children for hot-remove

After we send a PCI_EJECTION_COMPLETE message to the host, the host will
immediately send us a PCI_BUS_RELATIONS message with
relations->device_count == 0, so pci_devices_present_work(), running on
another thread, can find the being-ejected device, mark the
hpdev->reported_missing to true, and run list_move_tail()/list_del() for
the device -- this races hv_eject_device_work() -> list_del().

Move the list_del() in hv_eject_device_work() to an earlier place, i.e.,
before we send PCI_EJECTION_COMPLETE, so later the
pci_devices_present_work() can't see the device.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jake Oshins <jakeo@microsoft.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>
drivers/pci/host/pci-hyperv.c