]> git.karo-electronics.de Git - linux-beck.git/commit
[media] drivers/media/media-device: fix double free bug in _unregister()
authorMax Kellermann <max.kellermann@gmail.com>
Tue, 9 Aug 2016 21:33:03 +0000 (18:33 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 18 Nov 2016 17:29:27 +0000 (15:29 -0200)
commite7cd17a29d72868aa5cfbbd4de7c54a28ed30ff0
tree29b9bdca185608f2d8f29879fc4c0efeeb6c56fc
parent6753743e11540b7fc54d03771458e2bd91ba411b
[media] drivers/media/media-device: fix double free bug in _unregister()

While removing all interfaces in media_device_unregister(), all
media_interface pointers are freed.  This is illegal and results in
double kfree() if any media_interface is still linked at this point;
maybe because a userspace process still has a file handle.  Once the
process closes the file handle, dvb_media_device_free() gets called,
which frees the dvb_device.intf_devnode again.

This patch removes the unnecessary kfree() call, and documents who's
responsible for really freeing it.

Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/media-device.c