]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86/fpu: Change xstateregs_get()/set() to use ->xsave.i387 rather than ->fxsave
authorOleg Nesterov <oleg@redhat.com>
Tue, 10 Mar 2015 06:06:24 +0000 (07:06 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Mar 2015 06:14:31 +0000 (07:14 +0100)
commite7f180dcd8ab48f18b20d7e8a7e9b39192bdf8e0
tree96aeb3f9e38c888728417376daa7ab92472f8c5d
parentae486033b980346eb6a77240101210cb66924a91
x86/fpu: Change xstateregs_get()/set() to use ->xsave.i387 rather than ->fxsave

This is a cosmetic change: xstateregs_get() and xstateregs_set()
abuse ->fxsave to access xsave->i387.sw_reserved.

This practice is correct, ->fxsave and xsave->i387 share the same memory,
but IMHO this looks confusing.

And we can make this code more readable if we add a
"struct xsave_struct *" local variable as well.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tavis Ormandy <taviso@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1425967585-4725-1-git-send-email-bp@alien8.de
Link: http://lkml.kernel.org/r/20150302183237.GB23085@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/i387.c