]> git.karo-electronics.de Git - karo-tx-linux.git/commit
scsi_transport_sas: fix delete vs scan race
authorDan Williams <dan.j.williams@intel.com>
Tue, 20 Mar 2012 17:58:38 +0000 (10:58 -0700)
committerDan Williams <dan.j.williams@intel.com>
Wed, 11 Apr 2012 02:15:23 +0000 (19:15 -0700)
commite81dcce46fdbb2c968d7314c2f19da3c2bba24d1
tree25d1d2f7d36fb0933db4320ab5af8e32479b7333
parent55c53f6aed389e9e789df8d8e65d728ac125dba1
scsi_transport_sas: fix delete vs scan race

The following crash results from cases where the end_device has been
removed before scsi_sysfs_add_sdev has had a chance to run.

 BUG: unable to handle kernel NULL pointer dereference at 0000000000000098
 IP: [<ffffffff8115e100>] sysfs_create_dir+0x32/0xb6
 ...
 Call Trace:
  [<ffffffff8125e4a8>] kobject_add_internal+0x120/0x1e3
  [<ffffffff81075149>] ? trace_hardirqs_on+0xd/0xf
  [<ffffffff8125e641>] kobject_add_varg+0x41/0x50
  [<ffffffff8125e70b>] kobject_add+0x64/0x66
  [<ffffffff8131122b>] device_add+0x12d/0x63a
  [<ffffffff814b65ea>] ? _raw_spin_unlock_irqrestore+0x47/0x56
  [<ffffffff8107de15>] ? module_refcount+0x89/0xa0
  [<ffffffff8132f348>] scsi_sysfs_add_sdev+0x4e/0x28a
  [<ffffffff8132dcbb>] do_scan_async+0x9c/0x145

...teach sas_rphy_remove to wait for async scanning to quiesce before
removing the end_device.  It seems this is a more general problem [1],
but this patch only addresses sas transport.

[1]: 23edb6e [SCSI] mpt2sas: Do not set sas_device->starget to NULL from
the slave_destroy callback when all the LUNS have been deleted

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/scsi/scsi_transport_sas.c