]> git.karo-electronics.de Git - karo-tx-linux.git/commit
svcrpc: explicitly reject compounds that are not padded out to 4-byte multiple
authorJeff Layton <jlayton@redhat.com>
Mon, 10 Mar 2014 15:34:55 +0000 (11:34 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 27 Mar 2014 20:31:58 +0000 (16:31 -0400)
commite874f9f8e04cb67351893894dfb9fbcd25e62fa2
tree88c14bec77d7b36f741dc88242003ce7b8055e88
parent45481201009e33a5e61c78fbe14ccc02b066742b
svcrpc: explicitly reject compounds that are not padded out to 4-byte multiple

We have a WARN_ON in the nfsd4_decode_write() that tells us when the
client has sent a request that is not padded out properly according to
RFC4506. A WARN_ON really isn't appropriate in this case though since
this indicates a client bug, not a server one.

Move this check out to the top-level compound decoder and have it just
explicitly return an error. Also add a dprintk() that shows the client
address and xid to help track down clients and frames that trigger it.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4xdr.c