]> git.karo-electronics.de Git - linux-beck.git/commit
[media] rcar_vin: move buffer management to .stop_streaming handler
authorWilliam Towle <william.towle@codethink.co.uk>
Mon, 26 Jan 2015 17:08:40 +0000 (14:08 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 2 Feb 2015 12:42:48 +0000 (10:42 -0200)
commite99f0115e56ce4c4cda269cd21b25f7e14fa548f
tree9a7441a634cda46f4bbdc9217f19334c5a61471b
parent4abec46833c923c1be8dfee1d4eb1fff12cceb21
[media] rcar_vin: move buffer management to .stop_streaming handler

This commit moves the "buffer in use" logic from the .buf_cleanup
handler into .stop_streaming, based on advice that this is its
proper logical home.

By ensuring the list of pointers in priv->queue_buf[] is managed
as soon as possible, we avoid warnings concerning buffers in ACTIVE
state when the system cleans up after streaming stops. This fixes a
problem with modification of buffers after their content has been
cleared for passing to userspace.

After the refactoring, the buf_init and buf_cleanup functions were
found to contain only initialisation/release steps as are carried out
elsewhere if omitted; these functions and references were removed.

Signed-off-by: William Towle <william.towle@codethink.co.uk>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/soc_camera/rcar_vin.c