]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drop_monitor: Make updating data->skb smp safe
authorNeil Horman <nhorman@tuxdriver.com>
Fri, 27 Apr 2012 10:11:49 +0000 (10:11 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 9 Aug 2012 23:25:15 +0000 (00:25 +0100)
commitea39e338f9bb5eb5b3e568cbe7475549d67ef128
tree59193b47bb9febc821cea1a39c24b673f192cb83
parentcaaf10b6ccdb774387b298f9935dc9a81b4a86bc
drop_monitor: Make updating data->skb smp safe

commit 3885ca785a3618593226687ced84f3f336dc3860 upstream.

Eric Dumazet pointed out to me that the drop_monitor protocol has some holes in
its smp protections.  Specifically, its possible to replace data->skb while its
being written.  This patch corrects that by making data->skb an rcu protected
variable.  That will prevent it from being overwritten while a tracepoint is
modifying it.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Miller <davem@davemloft.net>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/drop_monitor.c