]> git.karo-electronics.de Git - karo-tx-linux.git/commit
pinctrl: rza1: Remove unneeded wrong check for wrong variable
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 30 Jun 2017 06:57:39 +0000 (08:57 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 30 Jun 2017 13:46:38 +0000 (15:46 +0200)
commitea4083165fbb322b69a59588a283b7c98bd42db3
treeff1b5fb36d66d81ba1ffa27e173d7d82f3ecb75c
parentd2a2c80815edfeecb189e6fbef8c2f2421018568
pinctrl: rza1: Remove unneeded wrong check for wrong variable

Depending on compiler version:

    drivers/pinctrl/pinctrl-rza1.c: In function ‘rza1_pinctrl_probe’:
    drivers/pinctrl/pinctrl-rza1.c:1260:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (ret)
 ^

Indeed, the result returned by platform_get_resource() was stored in
"res", not "ret".  In addition, the correct error check would be
"if (!res)", as platform_get_resource() does not return an error code,
but returns NULL on failure.

However, as devm_ioremap_resource() verifies the validity of the passed
resource pointer anyway, the check can just be removed.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 5a49b644b3075f88 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-rza1.c