]> git.karo-electronics.de Git - linux-beck.git/commit
sky2: avoid pci write posting after disabling irqs
authorLino Sanfilippo <LinoSanfilippo@gmx.de>
Sun, 30 Nov 2014 11:56:51 +0000 (12:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Dec 2014 05:33:20 +0000 (21:33 -0800)
commitea589e9b7838f5d1c3d4998f9fe08854872187fc
tree71a9c11f313c8d5e67f056c9330c882e1e15ce69
parent6276288a4c1f755e6b65b0f2e1177855b0340e31
sky2: avoid pci write posting after disabling irqs

In sky2_change_mtu setting B0_IMSK to 0 may be delayed due to PCI write posting
which could result in irqs being still active when synchronize_irq is called.
Since we are not prepared to handle any further irqs after synchronize_irq
(our resources are freed after that) force the write by a consecutive read from
the same register.
Similar situation in sky2_all_down: Here we disabled irqs by a write to B0_IMSK
but did not ensure that this write took place before synchronize_irq. Fix that
too.

Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/sky2.c