]> git.karo-electronics.de Git - karo-tx-linux.git/commit
gro: Reset dev pointer on reuse
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 30 Jan 2011 04:44:54 +0000 (20:44 -0800)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:06 +0000 (10:57 -0400)
commitec52b9005a454e0a4e3e1c1a04222fcc0a4073fc
tree68f4bbc6615f58a252783e238ec6536724f49ce3
parentebe451b0dd80704dc56e06c35690a47d26be149b
gro: Reset dev pointer on reuse

commit 66c46d741e2e60f0e8b625b80edb0ab820c46d7a upstream.

On older kernels the VLAN code may zero skb->dev before dropping
it and causing it to be reused by GRO.

Unfortunately we didn't reset skb->dev in that case which causes
the next GRO user to get a bogus skb->dev pointer.

This particular problem no longer happens with the current upstream
kernel due to changes in VLAN processing.

However, for correctness we should still reset the skb->dev pointer
in the GRO reuse function in case a future user does the same thing.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/core/dev.c