]> git.karo-electronics.de Git - linux-beck.git/commit
pda_power: Fix ac_draw usage before it being set
authorPaul Parsons <lost.distance@yahoo.com>
Thu, 20 Sep 2012 21:26:05 +0000 (14:26 -0700)
committerAnton Vorontsov <anton.vorontsov@linaro.org>
Thu, 20 Sep 2012 21:27:34 +0000 (14:27 -0700)
commitec60ea5cd6c9f4b249de1580b8ebfa430055008c
treeb481a1f8207bc7dda61ce2ec1b60e34f37032ad6
parent2815b786c3bb86fff97f1f6e2f0874903ff2339b
pda_power: Fix ac_draw usage before it being set

When I reboot my iPAQ hx4700 in its cradle, the battery will not begin
to charge even though the AC supply is connected. Charging will start
only after the PDA power driver is tickled by some other power event,
such as reseating the iPAQ in its cradle or connecting the USB cable.

The problem lies in pda_power_probe(), where ac_draw is used by the call
to update_charger() before being set by the call to regulator_get().

Moving the regulator_get() call to before the update_charger() call
fixes the problem.

Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
Cc: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
drivers/power/pda_power.c