]> git.karo-electronics.de Git - linux-beck.git/commit
gpio: stmpe: drop references to "virtual" IRQ, fix bug
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Oct 2013 17:51:38 +0000 (19:51 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 16 Oct 2013 07:59:53 +0000 (09:59 +0200)
commited05e204af5a2a7814858407bfd698d51e31f938
treef13c8d098a36c5e375f75c5c77afe55e2f723227
parentc0d6c1ad0ad8fa1b7c2148ba918fd5d64a51166a
gpio: stmpe: drop references to "virtual" IRQ, fix bug

Rename the argument "virq" to just "irq", this IRQ isn't any
more "virtual" than any other Linux IRQ number, we use "hwirq"
for the actual hw-numbers, "virq" is just bogus.

When doing this I see that the hwirq argument is used
for mapping rather than the Linux IRQ in the map function.
This doesn't look right. Use the Linux IRQ instead.

I cannot test this patch so I don't know if the mapping change
is correct, however since absolutely every other driver does
it the other way around this doesn't look sound at all. Please
help out with review.

Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
Cc: Jean-Nicolas Graux <jean-nicolas.graux@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-stmpe.c