]> git.karo-electronics.de Git - karo-tx-linux.git/commit
SCSI: qla2xxx: Return a FAILED status when abort mailbox-command fails.
authorMichael Reed <mdr@sgi.com>
Fri, 24 Oct 2008 22:13:47 +0000 (15:13 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 20 Nov 2008 22:54:50 +0000 (14:54 -0800)
commited07e187be0e13b8043a685cbe43df4adf82b856
tree0a7314c705cb7f329c898676d11bafeaf6848d38
parentc71aa7304abab14c23d72c468ecf039c405d418e
SCSI: qla2xxx: Return a FAILED status when abort mailbox-command fails.

commit 5bff55db3dc4d659f46b4d2fce2f61c1964c2762 upstream.

Mike Reed noted
(https://bugzilla.novell.com/show_bug.cgi?id=421330) that the
driver was incorrectly returning a SUCCESS status if the driver's
request to the firmware to abort a command failed.  By doing so,
the mid-layer believed, incorrectly, that the command has
completed and has been returned (ultimately clearing
scsi_cmnd.request_buffer) yet the driver still has the command.
What should correctly happen is a mid-layer escalation
(device-reset, etc.) of recovery during which the driver will
eventually return the outstanding commands to the mid-layer.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/qla2xxx/qla_os.c