]> git.karo-electronics.de Git - linux-beck.git/commit
[media] af9033: Don't export functions for the hardware filter
authorMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 14 Mar 2014 17:29:06 +0000 (14:29 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 14 Mar 2014 23:26:59 +0000 (20:26 -0300)
commited97a6fe5308e5982d118a25f0697b791af5ec50
tree3aefde16fcc9edf3c402347fab583eceb1aae44b
parentb24c2b4fb126007e36c5a67461527a5bfed33d17
[media] af9033: Don't export functions for the hardware filter

Exporting functions for hardware filter is a bad idea, as it
breaks compilation if:
CONFIG_DVB_USB_AF9035=y
CONFIG_DVB_AF9033=m

Because the PID filter function calls would be hardcoded at
af9035.

The same doesn't happen with af9033_attach() because the
dvb_attach() doesn't hardcode it. Instead, it dynamically
links it at runtime.

However, calling dvb_attach() multiple times is problematic,
as it increments module kref.

So, the better is to pass one parameter for the af9033 module
to fill the hardware filters, and then use it inside af9035.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/dvb-frontends/af9033.c
drivers/media/dvb-frontends/af9033.h
drivers/media/usb/dvb-usb-v2/af9035.c
drivers/media/usb/dvb-usb-v2/af9035.h