]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/atomic-helpers: Saner encoder/crtc callbacks
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 22 Jan 2015 15:36:24 +0000 (16:36 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 27 Jan 2015 09:02:43 +0000 (10:02 +0100)
commitee0a89cf3c2c550e6d877dda21dd2947afb90cb6
tree9da7f98114ddc7ca085a169b0a881efc1c80b273
parentf02ad907cd9e7fe3a6405d2d005840912f1ed258
drm/atomic-helpers: Saner encoder/crtc callbacks

For historical reasons going all the way back to how the Xrandr code
was implemented the semantics of the callbacks used to enable/disable
crtcs and encoders are ... interesting.

But with atomic helpers all that complexity has been binned, with only
a well-defined on/off action left. Unfortunately the names stuck.

Let's fix that by adding enable/disable hooks every, make them the
preferred variant for atomic and update documentations.

Later on we add debug warnings when drivers have deprecated hooks. But
while everything is in-flight with lots of drivers converting to
atomic that's a bit too much - better wait for things to settle a bit
first.

v2: Fix kerneldoc, reported by Wu Fengguang.

Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_atomic_helper.c
include/drm/drm_crtc_helper.h