]> git.karo-electronics.de Git - linux-beck.git/commit
ASoC: davinci-pcm: fix audible glitch on 2nd ping-pong playback
authorBen Gardiner <bengardiner@nanometrics.ca>
Tue, 24 May 2011 18:50:18 +0000 (14:50 -0400)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 25 May 2011 11:14:30 +0000 (19:14 +0800)
commitef39eb6f212996ede8da47ef45e6dffff1121ec7
tree5cb3b33659f4e7e280af765124cd8bc2a7175f96
parentacb8e2666eba7417e2fab783f86dbe067c3e815f
ASoC: davinci-pcm: fix audible glitch on 2nd ping-pong playback

The release of the dma channels was being performed in prepare and there was a
edma_resume call for the asp-channel only being executed on START, RESUME and
PAUSE_RELEASE.

The mcasp on da850evm with ping-pong buffers enabled was exhibiting an audible
glitch on every playback after the first. It was determined through trial and
error that the following two changes fix this problem:

1) Move the edma_start calls from prepare to trigger and 2) reverse the order
of starting the asp and ram channels.

Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
Reviewed-by: Steven Faludi <stevenfaludi@nanometrics.ca>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/davinci/davinci-pcm.c