]> git.karo-electronics.de Git - karo-tx-linux.git/commit
p54: Initialize extra_len in p54_tx_80211
authorJason Conti <jason.conti@gmail.com>
Thu, 7 Apr 2011 19:09:57 +0000 (21:09 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 9 May 2011 22:54:46 +0000 (15:54 -0700)
commitef6fc37610655817ebfd0f68dbabba9ae81255f2
treef81bedb2738b31c785f6c0993df5cdbef3b454da
parent752bdca00326ad699ede9f92b3a5978e13f1fe45
p54: Initialize extra_len in p54_tx_80211

commit a6756da9eace8b4af73e9dea43f1fc2889224c94 upstream.

This patch fixes a very serious off-by-one bug in
the driver, which could leave the device in an
unresponsive state.

The problem was that the extra_len variable [used to
reserve extra scratch buffer space for the firmware]
was left uninitialized. Because p54_assign_address
later needs the value to reserve additional space,
the resulting frame could be to big for the small
device's memory window and everything would
immediately come to a grinding halt.

Reference: https://bugs.launchpad.net/bugs/722185

Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Jason Conti <jason.conti@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/p54/txrx.c