]> git.karo-electronics.de Git - linux-beck.git/commit
Btrfs: fix BUG_ON in btrfs_mark_buffer_dirty
authorLiu Bo <bo.li.liu@oracle.com>
Fri, 2 Sep 2016 19:35:34 +0000 (12:35 -0700)
committerFilipe Manana <fdmanana@suse.com>
Wed, 23 Nov 2016 20:23:20 +0000 (20:23 +0000)
commitef85b25e982b5bba1530b936e283ef129f02ab9d
treee11f95703caf9024ec01611bf4751cba6f8fa267
parent2a2a83de548f7afe2c27e51cbc9ff761cba2b61b
Btrfs: fix BUG_ON in btrfs_mark_buffer_dirty

This can only happen with CONFIG_BTRFS_FS_CHECK_INTEGRITY=y.

Commit 1ba98d0 ("Btrfs: detect corruption when non-root leaf has zero item")
assumes that a leaf is its root when leaf->bytenr == btrfs_root_bytenr(root),
however, we should not use btrfs_root_bytenr(root) since it's mainly got
updated during committing transaction.  So the check can fail when doing
COW on this leaf while it is a root.

This changes to use "if (leaf == btrfs_root_node(root))" instead, just like
how we check whether leaf is a root in __btrfs_cow_block().

Fixes: 1ba98d086fe3 (Btrfs: detect corruption when non-root leaf has zero item)
Cc: stable@vger.kernel.org # 4.8+
Reported-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
fs/btrfs/disk-io.c