]> git.karo-electronics.de Git - karo-tx-linux.git/commit
powerpc: Add isync to copy_and_flush
authorMichael Neuling <michael.neuling@au1.ibm.com>
Wed, 24 Apr 2013 00:30:09 +0000 (00:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2013 03:33:03 +0000 (20:33 -0700)
commitefaa9d79ccb5491181ea100dc6a9c575f626ef5a
treeb24864edeee013e7b3c413d813df66b00a7a9f61
parent3e33f340b72643250afe21f8a0fc5b90f543a169
powerpc: Add isync to copy_and_flush

commit 29ce3c5073057991217916abc25628e906911757 upstream.

In __after_prom_start we copy the kernel down to zero in two calls to
copy_and_flush.  After the first call (copy from 0 to copy_to_here:)
we jump to the newly copied code soon after.

Unfortunately there's no isync between the copy of this code and the
jump to it.  Hence it's possible that stale instructions could still be
in the icache or pipeline before we branch to it.

We've seen this on real machines and it's results in no console output
after:
  calling quiesce...
  returning from prom_init

The below adds an isync to ensure that the copy and flushing has
completed before any branching to the new instructions occurs.

Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/kernel/head_64.S