]> git.karo-electronics.de Git - karo-tx-linux.git/commit
of: device: Fix overflow of coherent_dma_mask
authorSricharan R <sricharan@codeaurora.org>
Mon, 10 Apr 2017 11:21:00 +0000 (16:51 +0530)
committerJoerg Roedel <jroedel@suse.de>
Thu, 20 Apr 2017 14:31:06 +0000 (16:31 +0200)
commitefc8551a276faab19d85079da02c5fb602b0dcbe
treed4bc742878d00fba40a4b2de45eedbac7ae1aa5c
parent1d9029d440e40b276c0691caed1de10c42d96bef
of: device: Fix overflow of coherent_dma_mask

Size of the dma-range is calculated as coherent_dma_mask + 1
and passed to arch_setup_dma_ops further. It overflows when
the coherent_dma_mask is set for full 64 bits 0xFFFFFFFFFFFFFFFF,
resulting in size getting passed as 0 wrongly. Fix this by
passsing in max(mask, mask + 1). Note that in this case
when the mask is set to full 64bits, we will be passing the mask
itself to arch_setup_dma_ops instead of the size. The real fix
for this should be to make arch_setup_dma_ops receive the
mask and handle it, to be done in the future.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sricharan R <sricharan@codeaurora.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/of/device.c