]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ASoC: hdmi-codec: callback function will be called with private data
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 24 Jun 2016 02:47:55 +0000 (02:47 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 27 Jun 2016 17:53:15 +0000 (18:53 +0100)
commitefc9194bcff84666832c6493bafa92029ac6634c
tree5606d09a3a392ec3b8c401c762259cd7f7a509ce
parent1a695a905c18548062509178b98bc91e67510864
ASoC: hdmi-codec: callback function will be called with private data

Current hdmi-codec driver is assuming that it will be registered
from HDMI driver. Because of this assumption, each callback function
has struct device pointer which is parent device (= HDMI).
Then, it can use dev_get_drvdata() to get private data.

OTOH, on some SoC/HDMI case, SoC has VIDEO/SOUND and HDMI IPs.
This case, it needs SoC VIDEO, SoC SOUND and HDMI video, HDMI codec
driver. In DesignWare HDMI IP case, SoC VIDEO (= DRM/KMS) driver tries
to bind DesignWare HDMI video driver, and HDMI codec driver
(= hdmi-codec). This case, above "parent device" of HDMI codec driver
is DRM/KMS driver and its "device" already has private data.

And, from DT and ASoC CPU/Codec/Card binding point of view, HDMI codec
(= hdmi-codec) needs to have "parent device" (= DRM/KMS), otherwise,
it never detect sound card.

Because of these reasons, some driver can't use dev_get_drvdata() to
get private data on hdmi-codec driver. This patch add new void pointer
on hdmi_codec_pdata for private data, and callback function will be
called with it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/hdmi-codec.h
sound/soc/codecs/hdmi-codec.c