]> git.karo-electronics.de Git - linux-beck.git/commit
workqueue: clear POOL_DISASSOCIATED in rebind_workers()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 3 Jun 2014 07:33:27 +0000 (15:33 +0800)
committerTejun Heo <tj@kernel.org>
Thu, 19 Jun 2014 19:43:33 +0000 (15:43 -0400)
commitf05b558d7e0368e0511a098c4beb9654e41246c4
tree46e5a4baeb2fb82ceacfe3e8db263be12b1819ec
parentfb009e3a998e48fb33436bf9b563c82801a7329c
workqueue: clear POOL_DISASSOCIATED in rebind_workers()

The commit a9ab775bcadf ("workqueue: directly restore CPU affinity of
workers from CPU_ONLINE") moved the pool->lock into rebind_workers()
without also moving "pool->flags &= ~POOL_DISASSOCIATED".

There is nothing wrong with "pool->flags &= ~POOL_DISASSOCIATED" not
being moved together, but there isn't any benefit either. We move it
into rebind_workers() and achieve these benefits:

1) Better readability.  POOL_DISASSOCIATED is cleared in
   rebind_workers() as expected.

2) When POOL_DISASSOCIATED is cleared, we can ensure that all the
   running workers of the pool are on the local CPU (pool->cpu).

tj: Cosmetic updates to the code and description.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c