]> git.karo-electronics.de Git - linux-beck.git/commit
xfs: don't leave EFIs on AIL on mount failure
authorBrian Foster <bfoster@redhat.com>
Tue, 18 Aug 2015 23:58:36 +0000 (09:58 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 18 Aug 2015 23:58:36 +0000 (09:58 +1000)
commitf0b2efad16e78623b5a156f6e4e9166907b83155
tree82ebc3e9a7524046d748dd0bebae3caeb9bc91fd
parente32a1d1fbf6eb2bdc24aa0502e827ff4d2234604
xfs: don't leave EFIs on AIL on mount failure

Log recovery occurs in two phases at mount time. In the first phase,
EFIs and EFDs are processed and potentially cancelled out. EFIs without
EFD objects are inserted into the AIL for processing and recovery in the
second phase. xfs_mountfs() runs various other operations between the
phases and is thus subject to failure. If failure occurs after the first
phase but before the second, pending EFIs sit on the AIL, pin it and
cause the mount to hang.

Update the mount sequence to ensure that pending EFIs are cancelled in
the event of failure. Add a recovery cancellation mechanism to iterate
the AIL and cancel all EFI items when requested. Plumb cancellation
support through the log mount finish helper and update xfs_mountfs() to
invoke cancellation in the event of failure after recovery has started.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_log.c
fs/xfs/xfs_log.h
fs/xfs/xfs_log_priv.h
fs/xfs/xfs_log_recover.c
fs/xfs/xfs_mount.c