]> git.karo-electronics.de Git - linux-beck.git/commit
sctp: Use correct sideffect command in duplicate cookie handling
authorVlad Yasevich <vyasevich@gmail.com>
Tue, 12 Mar 2013 15:53:23 +0000 (15:53 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Mar 2013 13:59:21 +0000 (09:59 -0400)
commitf2815633504b442ca0b0605c16bf3d88a3a0fcea
treefe66c3fb3d62c59767f056cd358ba35a833b4736
parent7c6cdead7cc9a99650d15497aae47d7472217eb1
sctp: Use correct sideffect command in duplicate cookie handling

When SCTP is done processing a duplicate cookie chunk, it tries
to delete a newly created association.  For that, it has to set
the right association for the side-effect processing to work.
However, when it uses the SCTP_CMD_NEW_ASOC command, that performs
more work then really needed (like hashing the associationa and
assigning it an id) and there is no point to do that only to
delete the association as a next step.  In fact, it also creates
an impossible condition where an association may be found by
the getsockopt() call, and that association is empty.  This
causes a crash in some sctp getsockopts.

The solution is rather simple.  We simply use SCTP_CMD_SET_ASOC
command that doesn't have all the overhead and does exactly
what we need.

Reported-by: Karl Heiss <kheiss@gmail.com>
Tested-by: Karl Heiss <kheiss@gmail.com>
CC: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_statefuns.c