]> git.karo-electronics.de Git - linux-beck.git/commit
staging: rtl8192u: replace macro rx_hal_is_cck_rate() in r8192U_core.c
authorXenia Ragiadakou <burzalodowa@gmail.com>
Tue, 4 Jun 2013 20:32:32 +0000 (23:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jun 2013 22:37:22 +0000 (15:37 -0700)
commitf2c3d800972670fb49bc0ebaeb02450aa591eb0a
tree3d7037ba2d239cbeccd528e8d4420422c0cd365e
parent88e5a934d3836b9eb948b46f402357c4c0e0eafe
staging: rtl8192u: replace macro rx_hal_is_cck_rate() in r8192U_core.c

This patch replaces macro rx_hal_is_cck_rate() with
the static inline function rx_hal_is_cck_rate().

This replacement was suggested by Dan Carpenter and
has the following benefits:
- improves code readability
- guarantees type safety
- improves code efficiency by enforcing the evaluation of
  the simple boolean expression (!pdrvinfo->RxHT) to be
  done before the evaluation of the more complex one
  (pdrvinfo->RxRate == DESC90_RATE1M ||
   pdrvinfo->RxRate == DESC90_RATE2M ||
   pdrvinfo->RxRate == DESC90_RATE5_5M ||
   pdrvinfo->RxRate == DESC90_RATE11M)

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_core.c