]> git.karo-electronics.de Git - karo-tx-linux.git/commit
of: Fix iteration bug over CPU reg properties
authorGrant Likely <grant.likely@linaro.org>
Fri, 4 Oct 2013 16:24:26 +0000 (17:24 +0100)
committerGrant Likely <grant.likely@linaro.org>
Tue, 15 Oct 2013 19:09:18 +0000 (20:09 +0100)
commitf3cea45a77c8ebdb7efad100e576eb6cb401bf25
treeae7be3718ae93dc224bee399384ae07d013d8c07
parentd1cb9d1af0bc11b7450a6032f43935c746609418
of: Fix iteration bug over CPU reg properties

The size of each hwid in a cpu nodes 'reg' property is defined by the
parents #address-cells property in the normal way. The cpu parsing code
has a bug where it will overrun the end of the property if
address-cells is greater than one. This commit fixes the problem by
adjusting the array size by the number of address cells. It also makes
sure address-cells isn't zero for that would cause an infinite loop.

v2: bail if #address-cells is zero instead of forcing to
    OF_ROOT_NODE_ADDR_CELLS_DEFAULT. Forcing it will cause the reg
    property to be parsed incorrectly.

Signed-off-by: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/of/base.c