]> git.karo-electronics.de Git - karo-tx-linux.git/commit
watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions
authorKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Sun, 9 Apr 2017 22:00:18 +0000 (15:00 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 28 Apr 2017 18:51:27 +0000 (21:51 +0300)
commitf583a884afecb16fcb8200ebb9956ea369aff57f
tree54e733c3e4e4c653b769f3963b37e64d0d95c777
parent496702068597ff29092e724301f77b91864454b3
watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions

iTCO_wdt no_reboot_bit set/unset functions has lot of common code between
them. So merging these two functions into a single update function would
remove these unnecessary code duplications. This patch fixes this issue
by creating a no_reboot_bit update function to handle both set/unset
functions.

Also checking for iTCO version every time you make no_reboot_bit set/unset
call is inefficient and makes the code look complex. This can be improved
by performing this check once during device probe and selecting the
appropriate no_reboot_bit update function. This patch fixes this issue
by splitting the update function into multiple helper functions.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/watchdog/iTCO_wdt.c