]> git.karo-electronics.de Git - karo-tx-linux.git/commit
signal: Explain local_irq_save() call
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Mon, 5 May 2014 15:18:30 +0000 (08:18 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Thu, 26 Jun 2014 17:58:42 +0000 (10:58 -0700)
commitf593435c3082ed559ff9bba3c37fd9af48ef303b
tree7aa635f706ac06ae32011397691690b0e0cdb347
parent041ae34f21d8a51c1c126ef2299043367c3c88ef
signal: Explain local_irq_save() call

The explicit local_irq_save() in __lock_task_sighand() is needed to avoid
a potential deadlock condition, as noted in a841796f11c90d53 (signal:
align __lock_task_sighand() irq disabling and RCU).  However, someone
reading the code might be forgiven for concluding that this separate
local_irq_save() was completely unnecessary.  This commit therefore adds
a comment referencing the shiny new block comment on rcu_read_unlock().

Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
kernel/signal.c