]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sysfs: handle failure path correctly for readdir()
authorMing Lei <ming.lei@canonical.com>
Wed, 20 Mar 2013 15:25:25 +0000 (23:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2013 16:25:46 +0000 (09:25 -0700)
commitf67b04d44657c874c34ea461633463803755a7c9
tree5b6166a24017e47cc627f282ec6783b45538392b
parent9e14083e68a88bc48631d59a3bbdf4a800c1646c
sysfs: handle failure path correctly for readdir()

commit e5110f411d2ee35bf8d202ccca2e89c633060dca upstream.

In case of 'if (filp->f_pos ==  0 or 1)' of sysfs_readdir(),
the failure from filldir() isn't handled, and the reference counter
of the sysfs_dirent object pointed by filp->private_data will be
released without clearing filp->private_data, so use after free
bug will be triggered later.

This patch returns immeadiately under the situation for fixing the bug,
and it is reasonable to return from readdir() when filldir() fails.

Reported-by: Dave Jones <davej@redhat.com>
Tested-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/dir.c