]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: fix circular dependency in of_mdio code
authorDaniel Mack <zonque@gmail.com>
Fri, 27 Jun 2014 23:23:35 +0000 (01:23 +0200)
committerNitin Garg <nitin.garg@freescale.com>
Fri, 16 Jan 2015 03:17:36 +0000 (21:17 -0600)
commitf6a4800566af2f0171f912582b29ab19c532be9a
tree553c4c97545ebf6f85c61baf327773b376be5e2f
parent3ee294ba59b4ebcf9657c4ba93505db1a81db880
net: fix circular dependency in of_mdio code

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a
circular dependency between libphy and of_mdio.

depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!

The problem is that of_mdio.c references &mdio_bus_type and libphy now
references of_mdiobus_link_phydev.

Fix this by not exporting of_mdiobus_link_phydev() from of_mdio.ko.
Make it a static function in mdio_bus.c instead.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-by: Jeff Mahoney <jeffm@suse.com>
Fixes: 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio_bus.c
drivers/of/of_mdio.c
include/linux/of_mdio.h