]> git.karo-electronics.de Git - karo-tx-linux.git/commit
PKT_SCHED: Fix illegal memory dereferences when dumping actions
authorThomas Graf <tgraf@suug.ch>
Tue, 7 Nov 2006 14:31:14 +0000 (15:31 +0100)
committerAdrian Bunk <bunk@stusta.de>
Tue, 7 Nov 2006 14:31:14 +0000 (15:31 +0100)
commitf6dde50d9deb831fdc89f06cc453c5cb87669972
tree59f8b910bc0384e6614e1451dd79e79a00ee43fe
parent118d32a5f209230c66a3b7d3874d1d5846ceb630
PKT_SCHED: Fix illegal memory dereferences when dumping actions

The TCA_ACT_KIND attribute is used without checking its
availability when dumping actions therefore leading to a
value of 0x4 being dereferenced.

The use of strcmp() in tc_lookup_action_n() isn't safe
when fed with string from an attribute without enforcing
proper NUL termination.

Both bugs can be triggered with malformed netlink message
and don't require any privileges.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
net/sched/act_api.c