]> git.karo-electronics.de Git - karo-tx-linux.git/commit
af_unix: limit unix_tot_inflight
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 24 Nov 2010 17:15:27 +0000 (09:15 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Jan 2011 21:58:26 +0000 (13:58 -0800)
commitf7e86272f0b8fcc627c3d4a42db21419f1995b9a
treeb2d0642f9532cb3c9f7f8394a2fb432df4ca8efd
parent306030ab289880475a63ebab1948ea300ec46d89
af_unix: limit unix_tot_inflight

[ Upstream commit 9915672d41273f5b77f1b3c29b391ffb7732b84b ]

Vegard Nossum found a unix socket OOM was possible, posting an exploit
program.

My analysis is we can eat all LOWMEM memory before unix_gc() being
called from unix_release_sock(). Moreover, the thread blocked in
unix_gc() can consume huge amount of time to perform cleanup because of
huge working set.

One way to handle this is to have a sensible limit on unix_tot_inflight,
tested from wait_for_unix_gc() and to force a call to unix_gc() if this
limit is hit.

This solves the OOM and also reduce overall latencies, and should not
slowdown normal workloads.

Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/unix/garbage.c